Handle polkit timeout during udev setup#2456
Conversation
buhtz
added
the
PR: Waiting for review
|
Hello Ajeem, thank you for your contribution and taking time to improve Back In Time. I appreciate it. On a quick initial review your PR looks good. I'll review it in detail later. Please note that currently I have to put all PRs on hold, because the Back In Time code base is in a transition phase. I am rewriting the mounting subsystem from scratch (PR #2449). Since the components are not well isolated, this affects nearly every file. To avoid complex merge conflicts, all other PRs are temporarily on hold. Best wishes, |
|
The new mount subsystem is read for testing incl. full gocryptfs support as encfs replacement. |
buhtz
left a comment
buhtz
left a comment
There was a problem hiding this comment.
Hello Ajeem,
thank you for this PR. Would be nice if you could add a changelog entry refering to the issue and also to your name and/or nick name.
Please pull/fetch first before doing modifications. I updated your branch to the latest dev version.
After that I am fine with merging it.
Regards,
Christian
buhtz
added
Feedback
| 'Timed out while waiting for the authentication dialog. ' | ||
| 'Please try again.' | ||
| ) | ||
| logger.error(msg, self) |
There was a problem hiding this comment.
Please don't translate log messages. Just user messages.
|
Hello Ajeem, can you please give me a life sign and explain your plans with this PR. Best, |
|
Hi, this PR has been inactive for several months. I have provided feedback and suggested changes, but there has been no response or update from your side. Please be aware that maintaining and completing the proposed changes is the responsibility of the PR author. I will not take over the implementation work. If you want this PR to be merged, please continue the discussion, address the review comments, and update the PR. Otherwise, I will close this PR without merging it. Thank you. |
2 participants
Summary: Prevent a crash when the authentication dialog times out while saving udev scheduling rules.
What changed:
Why:
When the polkit password prompt times out, the D-Bus call returns NoReply. That exception was not handled in the udev setup path, so the Manage Profiles dialog crashed instead of reporting the failure gracefully.
Verification:
Note:
I could not fully reproduce the Linux polkit dialog flow on macOS, so this is a traceback-driven fix.